[PATCH re-send]: Clean up logging of failed logins
dtucker at zip.com.au
Mon Apr 28 09:37:21 EST 2003
[sorry, forgot to CC the list with my first reply]
Ben Lindstrom wrote:
> sorry, Darren. Long over due comments.
That's OK, but I was wondering if anyone noticed.
> I like the patch idea, but I'd like to skip the whole 'chained function
> calls'. Plus it avoids closely packed #ifdef/#endifs.
Most of the login recording stuff (eg loginrec.c) is closely packed
#ifdefs and chained function calls.
> Just rename cray_login_failure() and loginfailed() to
> record_failed_login(), and change the #ifdef WITH_AIXAUTHENTICATE to
> #ifdef CUSTOM_LOGIN_FAILURE.
That means adding extraneous arguments to the cray function and changing
the "user" argument for both to either "char *" or "const char *".
loginfailed() is an AIX library function, so it can't be renamed but we
can create a function in port-aix.c. There's other stuff that might end
up in there (eg http://bugzilla.mindrot.org/show_bug.cgi?id=543).
> That way we can just #define CUSTOM_LOGIN_FAILURE in the aix/cray headers
> to activate it and we can keep things cleaner.
I'll rework it and see how it looks.
Darren Tucker (dtucker at zip.com.au)
GPG Fingerprint D9A3 86E9 7EEE AF4B B2D4 37C9 C982 80C7 8FF4 FA69
Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.
More information about the openssh-unix-dev