[PATCH re-send]: Clean up logging of failed logins

[Ben Lindstrom]

On Mon, 28 Apr 2003, Darren Tucker wrote:

> Ben Lindstrom wrote:
> > Just rename cray_login_failure() and loginfailed() to
> > record_failed_login(), and change the #ifdef WITH_AIXAUTHENTICATE to
> > #ifdef CUSTOM_LOGIN_FAILURE.
> >
> > That way we can just #define CUSTOM_LOGIN_FAILURE in the aix/cray headers
> > to activate it and we can keep things cleaner.
>
> I just had a quick look.  To this, both functions will need 4 arguments, 2
> extraneous on Cray, 1 on AIX.  What if the next platform that has this
> functionality needs another argument?  Plus there's an extra #ifdef in the
> mainline.
>

Not sure how this is different then your version.  If it needs more
functionality it is going to get bad for either case.  The only difference
is a middleman function in a syncable part of the CVS.

> Are you sure that's cleaner?
>

Maybe.  The #ifdef in place get left (BTW..I'm not again #ifdef.. I'm
against tightly packed ones that can be avoided).  Each system can
handle added failure support without it being in the way of resyncs.

I don't mind the #ifdef in the maintree.  Just want to avoid cases like
verifying passwords (closely patched insanely unreadable ifdef clusters
like in the password verification code).

- Ben