Call for testing: OpenSSH 6.8

[Tom G. Christensen]

On 26/02/15 01:27, Damien Miller wrote:
> On Thu, 26 Feb 2015, Damien Miller wrote:
>
>>> Yes I saw that later.
>>>
>>> The testsuite build fails on Solaris 2.6 thusly:
>> [...]
>>> regress/netcat.c:1037: error: 'struct msghdr' has no member named
>>> 'msg_control'
>>
>> ah, looks like we need to copy some bits from monitor_fdpass.c
>
> Perhaps like this:
>
<snip>

Seems to work. Tested it with Solaris 2.6 and 9.

ssh-keygen still segfaults in keygen-change.sh.
It works for ssh-ed25519 but the other types segfault.

ssh-keygen -p failed for ssh-rsa-key
ssh-keygen -p failed for ssh-dss-key
ssh-keygen -p failed for ecdsa-sha2-nistp256-key
ssh-keygen -p failed for ecdsa-sha2-nistp384-key
ssh-keygen -p failed for ecdsa-sha2-nistp521-key

Example:
Core was generated by 
`/export/home/tgc/buildpkg/openssh/src/openssh-git/ssh-keygen -p -P 
secret1 -N 2'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0xfedb4b14 in strlen () from /usr/lib/libc.so.1
(gdb) bt
#0  0xfedb4b14 in strlen () from /usr/lib/libc.so.1
#1  0xfee07a20 in _doprnt () from /usr/lib/libc.so.1
#2  0xfee095e0 in printf () from /usr/lib/libc.so.1
#3  0x00054650 in do_change_passphrase (pw=pw at entry=0x92b04) at 
ssh-keygen.c:1279
#4  0x000593c0 in main (argc=0, argv=0xffbfe6ac) at ssh-keygen.c:2530
(gdb) fram 3
#3  0x00054650 in do_change_passphrase (pw=pw at entry=0x92b04) at 
ssh-keygen.c:1279
1279            printf("Key has comment '%s'\n", comment);
(gdb) print comment
$1 = 0x0
(gdb)

$ ./ssh-keygen -q -N secret1 -t ssh-rsa -f /tmp/sshkey
$ ./ssh-keygen -p -P secret1 -N 2secret -f /tmp/sshkey
Segmentation Fault (core dumped)
$

They key seems to be fine though, ssh-keygen from 6.7p1 has no problems 
with it:
$ ssh-keygen -p -P secret1 -N 2secret -f /tmp/sshkey
Key has comment 'rsa w/o comment'
Your identification has been saved with the new passphrase.
$

-tgc