Call for testing: OpenSSH 6.8

Damien Miller djm at mindrot.org
Fri Feb 27 07:47:38 AEDT 2015


On Thu, 26 Feb 2015, Tom G. Christensen wrote:

> Seems to work. Tested it with Solaris 2.6 and 9.
> 
> ssh-keygen still segfaults in keygen-change.sh.
> It works for ssh-ed25519 but the other types segfault.

Thanks for the backtrace:

> #3  0x00054650 in do_change_passphrase (pw=pw at entry=0x92b04) at
> ssh-keygen.c:1279

I've commited this fix:

diff --git ssh-keygen.c ssh-keygen.c
index 4a5c402..facee42 100644
--- ssh-keygen.c
+++ ssh-keygen.c
@@ -1276,7 +1276,8 @@ do_change_passphrase(struct passwd *pw)
 		    identity_file, ssh_err(r));
 		exit(1);
 	}
-	printf("Key has comment '%s'\n", comment);
+	if (comment)
+		printf("Key has comment '%s'\n", comment);
 
 	/* Ask the new passphrase (twice). */
 	if (identity_new_passphrase) {


More information about the openssh-unix-dev mailing list