[PATCH] ssh-add: Support '@' in the user part of destination constraints

[Max Zettlmeißl]

On Fri, 6 Sept 2024 at 04:11, Damien Miller <djm at mindrot.org> wrote:
>
> Save yourself some trouble next time and read
> https://www.openssh.com/report.html -- tech at openbsd.org isn't a great
> place to report OpenSSH bugs. I read it only infrequently.

I read that page and was very unsure whether to submit it to tech@ or
openssh-unix-dev@, but since I saw that you pulled in all changes from
upstream and was not sure about the other way around and since the
report subpage was linked from the "For other systems" section, I
eventually went with tech at .
Now I know better for the future.

> Patch seems ok, but I think it makes sense to review all the
> user at host parsing; grep "str.*chr.*@" is a mess...
>
> I'll look at it.

Thanks.

I thought so too, especially to prevent a similar deviation in the
future. I took a brief look at the possibility of centralising all the
user and host splitting in a place but decided to leave that to
someone more familiar with the structure and style of the OpenSSH code
base, since the splitting was very interwoven with other parts more
specific to the respective function and I did not want to submit too
big of a patch as a new outsider.

I read your replies to the other thread and view this as fixed for now.