Call for testing: OpenSSH 10.1p1

[Sevan Janiyan]

On 01/10/2025 23:51, Darren Tucker wrote:
 > Does the patch below fix all instances?

Yep.
Took openssh-SNAP-20251002.tar.gz & applied your patch, then built & ran 
the test suite on OS X 10.4.11 PowerPC running on a G4 with OpenSSL 3.5.x
Test suite passed. Thanks :)

Just as a heads up. The Apple clang check only really works correctly on 
clang/macOS released in the last few years.
OS X 10.4 had GCC 4.0.1, 3.3
OS X 10.5 had GCC 4.2, 4.0, 3.3
OS X 10.6 had GCC 4.2, 40, llvm-gcc
OS X 10.7 had clang & llvm-gcc
OS X 10.8 had clang
And since 10.8 it's only been clang.
All OS versions since contain a cc, clang, gcc in /usr/bin
However, cc was always a symlink until recent versions of macOS (changed 
sometime since macOS 11)
On macOS 14 Sonoma, cc, clang, gcc are a hardlink to the same inode.

All compiler versions mention the word Apple.
On OS X 10.4, cc -v contains the following line among its output:
gcc version 4.0.1 (Apple Computer, Inc. build 5370)

On OS X 10.7
$ clang -v
Apple LLVM version 4.2 (clang-425.0.28) (based on LLVM 3.2svn)
Target: x86_64-apple-darwin11.4.2
Thread model: posix
$ gcc -v
Using built-in specs.
Target: i686-apple-darwin11
Configured with: 
/private/var/tmp/llvmgcc42/llvmgcc42-2336.11~182/src/configure 
--disable-checking --enable-werror 
--prefix=/Applications/Xcode.app/Contents/Developer/usr/llvm-gcc-4.2 
--mandir=/share/man --enable-languages=c,objc,c++,obj-c++ 
--program-prefix=llvm- --program-transform-name=/^[cg][^.-]*$/s/$/-4.2/ 
--with-slibdir=/usr/lib --build=i686-apple-darwin11 
--enable-llvm=/private/var/tmp/llvmgcc42/llvmgcc42-2336.11~182/dst-llvmCore/Developer/usr/local 
--program-prefix=i686-apple-darwin11- --host=x86_64-apple-darwin11 
--target=i686-apple-darwin11 --with-gxx-include-dir=/usr/include/c++/4.2.1
Thread model: posix
gcc version 4.2.1 (Based on Apple Inc. build 5658) (LLVM build 2336.11.00)

clang -v reported itself as "Apple LLVM" until macOS 10.13 or 10.14 (I 
don't have 10.14 at hand to confirm), but on 10.15, it looks as follows:

$ clang -v
Apple clang version 12.0.0 (clang-1200.0.32.29)
Target: x86_64-apple-darwin19.6.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin
$ gcc -v
Configured with: --prefix=/Library/Developer/CommandLineTools/usr 
--with-gxx-include-dir=/Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk/usr/include/c++/4.2.1
Apple clang version 12.0.0 (clang-1200.0.32.29)
Target: x86_64-apple-darwin19.6.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

Long story, short: when you're configuring on a version which clang 
reports as Apple LLVM, configure reports:
checking gcc version...
checking clang version... apple-

On OS X 10.4, with GCC:
checking gcc version... 4.0.1
checking clang version... apple-

Is it worth switching to ax_compiler_version from the autoconf-archive?
https://www.gnu.org/software/autoconf-archive/ax_compiler_version.html

Sincerely,


Sevan