SFTP Logging Redux.

[mouring at etoh.eviladmin.org]

Agreed.  If we are going to log anything it should be the success/failure
of the request.. not so much the request itself.

- Ben

On Wed, 20 Jun 2001, Robert Mooney wrote:

>
> It looks like you're logging the requested action, not the result.  For
> instance:
>
> log("(%d/%d/%s) File/Dir opened: %s (%s,%04o)"...);
> fd = open(name, flags, mode);
>
> Unless I'm missing something about the functionality of log(), I would
> expect it to come after the open(), and include information as to
> whether or not the action actually succeeded.
>
> Also, a switch to a) turn on logging, and b) set the verbosity of the
> logging would be cool.
>
> In general, I think it's easier for a developer to turn his back on
> your patch if it's adding functionality without requiring the user
> request it explicitly.
>
> Nice idea though, I would like to see something similar committed.
>
> - Rob
>
> : -----Original Message-----
> : From: owner-openssh-unix-dev at mindrot.org
> : [mailto:owner-openssh-unix-dev at mindrot.org]On Behalf Of Jason A . Dour
> : Sent: Wednesday, June 20, 2001 9:12 AM
> : To: openssh-unix-dev at mindrot.org
> : Subject: SFTP Logging Redux.
> :
> :
> : Sorry to repost, but I finally have the code on a machine that has
> : diff -u, and I've updated it for 2.9p2.  Attached is the unified
> : diff to add logging of SFTP activity to auth.info.
> :
> : If there is a more proper way to contrib patches, please let me
> : know.
> :
> :
> : Cheers,
> : Jason
> : # "Jason A. Dour" <jason at dour.org>                  http://dour.org/
> : # Founder / Executive Producer - PJ Harvey Online - http://pjh.org/
> :
>