OS/390 openssh

[Martin Kraemer]

On Wed, Oct 08, 2003 at 01:28:00PM +0200, Markus Friedl wrote:
> > -	buffer_put_string(&msg, blob, blen);
> > -	buffer_put_string(&msg, data, datalen);
> > +	buffer_put_binary(&msg, blob, blen);
> > +	buffer_put_binary(&msg, data, datalen);
> 
> wouldn't it be easier to treat all
> 	buffer_put_string
> as binary and do conversion only in
> 	buffer_put_cstring
> ?

Then again it would be necessary to check all buffer_put_string()'s
whether they should actually be buffer_put_cstring()'s....

When the patch was first written, IIRC there was no
buffer_put_cstring() yet, and I do not remember why it was added in the
first place.

But yes, it would be much better to have only two function, not three.

  Martin
-- 
<Martin.Kraemer at Fujitsu-Siemens.com>         |     Fujitsu Siemens
Fon: +49-89-636-46021, FAX: +49-89-636-47655 | 81730  Munich,  Germany