OS/390 openssh

Ben Lindstrom mouring at etoh.eviladmin.org
Thu Oct 9 03:19:17 EST 2003



On Wed, 8 Oct 2003, Darren Tucker wrote:

[..]
> Instead of doing this:
> >  #ifdef CUSTOM_FAILED_LOGIN
> >        if (authenticated == 0 && strcmp(method, "password") == 0)
> > +        {
> > +#if #system(bs2000)
> > +               record_failed_login_attempt(authctxt->user,
> [snip]
> >  #else
> >                 record_failed_login(authctxt->user, "ssh");
> >  #endif
> > +       }
> > +#endif
>
> Add another argument to record_failed_login() (eg "reason", maybe make it
> an enum), put your own record_failed_login() into port-bs2000.c and lose
> the #ifdefs.
>

Unless there is an extreme need for this change (IE, system fails) they
should be submited as separate patches.  Please provide a patch that
*ONLY* gets the platform to work.  Otherwise it will be ignored since we
will not seperate out "required" vs "nice" changes.

- Ben




More information about the openssh-unix-dev mailing list