OpenSSH-snap-20040212 and the use of krb5-config

[Darren Tucker]

Douglas E. Engert wrote:
> More or less, but the new code uses 
>        CPPFLAGS="$CPPFLAGS ${K5CFLAGS}/gssapi"

What guarantee is there that K5CFLAGS will contain only 
-I/path/to/includes?"  What happens if it contains, eg,
"-I/path/to/include -DSOME_FLAG"?

> Which uses the output of the krb5-config --cflag i.e. -I/some/location/include 
> were as the original uses 
>        CPPFLAGS="$CPPFLAGS -I${KRB5ROOT}/include/gssapi"
> The $KRB5ROOT may not be the same location as the output of krb5-config.
> 
> The extra check is only executed if gssapi is not found in the expected place,
> so when MIT fixes krb5-config so it finds the gssapi.h then the 
> extra check could be eliminated, and the tests could be combined. 

-- 
Darren Tucker (dtucker at zip.com.au)
GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4  37C9 C982 80C7 8FF4 FA69
     Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.