Call for testing: OpenSSH 7.7

[Jakub Jelen]

On Thu, 2018-03-22 at 14:42 +1100, Damien Miller wrote:
> Hi,
> 
> OpenSSH 7.7p1 is almost ready for release, so we would appreciate
> testing
> on as many platforms and systems as possible. This is a bugfix
> release.
> 
> [...]
> 
> Running the regression tests supplied with Portable OpenSSH does not
> require installation and is a simply:
> 
> $ ./configure && make tests

The localcommand test failed for me (for other reasons) and after some
more investigation, I found that the following commit introduced an pw
argument to the load_public_identity_files() function, but is
overwriting our local copy from main:

https://github.com/openssh/openssh-portable/commit/b7548b1

The following diff makes it using our copied pw variable instead of
overwriting it:

diff --git a/ssh.c b/ssh.c
index d3619fe2..98b15f6b 100644
--- a/ssh.c
+++ b/ssh.c
@@ -2041,8 +2041,6 @@ load_public_identity_files(struct passwd *pw)
 		free(keys);
 	}
 #endif /* ENABLE_PKCS11 */
-	if ((pw = getpwuid(original_real_uid)) == NULL)
-		fatal("load_public_identity_files: getpwuid failed");
 	for (i = 0; i < options.num_identity_files; i++) {
 		if (n_ids >= SSH_MAX_IDENTITY_FILES ||
 		    strcasecmp(options.identity_files[i], "none") ==
0) {


Regards,
-- 
Jakub Jelen
Software Engineer
Security Technologies
Red Hat, Inc.