Call for testing: OpenSSH 7.4

[Damien Miller]

On Sun, 18 Dec 2016, Tom G. Christensen wrote:

> On 14/12/16 01:53, Damien Miller wrote:
> > Hi,
> > 
> > OpenSSH 7.4 is almost ready for release, so we would appreciate testing
> > on as many platforms and systems as possible.
> 
> I've tested Solaris 2.6/sparc, 7/sparc, 8/sparc and 9/x86 using HEAD from the
> git repo.
> 
> All exhihit this error:
> test_utf8: ..
> regress/unittests/utf8/tests.c:52 test #3 "utf8_null"
> ASSERT_STRING_EQ(buf, wants) failed:
>          buf = (NULL) (len zu)
>        wants = (null) (len zu)
> gmake[1]: *** [unit] Error 134

Thanks for testing!

It looks like that test case relies on undefined behaviour (printf of NULL).
We should just disable it:

diff --git a/regress/unittests/utf8/tests.c b/regress/unittests/utf8/tests.c
index 6d06fa1..c2793ea 100644
--- a/regress/unittests/utf8/tests.c
+++ b/regress/unittests/utf8/tests.c
@@ -65,7 +65,6 @@ tests(void)
 	TEST_DONE();
 
 	badarg();
-	one("null", NULL, 8, 6, 6, "(null)");
 	one("empty", "", 2, 0, 0, "");
 	one("ascii", "x", -2, -2, -2, "x");
 	one("newline", "a\nb", -2, -2, -2, "a\nb");